Thoughts on Code Review
A nice code review methodology i discovered recently.
One hour once a week for Code Review Discussion.
Code Review Discussion: would be a meeting with all the team members where they give their feedback when a file is projected onto a screen.
File Selection and Review : 2-3 days before the actual Code Review Discussion the team lead needs to send 3-4 files (different each week) to the team. The team members need to find a few minutes over the 2-3 days everyday to do the review and come to the Code Review discussion with their comments.
What files to select for review: The list of the files should be such that probably one week only server side code is taken up (or may be just controllers or models or taglibs) and one day on the UI stuff like JS files. In this way it becomes a session where the team members start clarifying doubts about a certain technology and coding style and philosophy related to it. And also shift the focus from a certain individual to that particular piece of technology.
Key Points: More emphasis on healthy discussion than reflecting badly on the person whose code is being reviewed. Everyone should be encouraged to look into the code (juniors and seniors), and come up with reviews if possible. Its fine if all files are not reviewed but this gives understanding to the whole team as to what is the expectation with the code.

2 Comments, Comment or Ping
Zelym
Enjoyed reading this, will check back soon!
Nov 30th, 2010
Reply to “Thoughts on Code Review”